1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
|
import re
from typing import (
Union,
Optional,
List,
TYPE_CHECKING,
cast,
)
from collections.abc import Sequence, Iterable, Mapping
from debputy.filesystem_scan import VirtualPathBase
from debputy.linting.lint_util import LintState
from debputy.lsp.debputy_ls import DebputyLanguageServer
from debputy.lsp.lsp_features import (
lint_diagnostics,
lsp_standard_handler,
lsp_completer,
lsp_semantic_tokens_full,
SEMANTIC_TOKEN_TYPES_IDS,
SecondaryLanguage,
LanguageDispatchRule,
)
from debputy.lsp.quickfixes import (
propose_remove_range_quick_fix,
propose_correct_text_quick_fix,
)
from debputy.lsp.text_util import (
SemanticTokensState,
)
from debputy.lsprotocol.types import (
CompletionItem,
CompletionList,
CompletionParams,
TEXT_DOCUMENT_WILL_SAVE_WAIT_UNTIL,
SemanticTokensParams,
SemanticTokens,
SemanticTokenTypes,
Position,
CompletionItemKind,
CompletionItemLabelDetails,
)
if TYPE_CHECKING:
import lsprotocol.types as types
else:
import debputy.lsprotocol.types as types
try:
from debputy.lsp.vendoring._deb822_repro.locatable import (
Position as TEPosition,
Range as TERange,
START_POSITION,
)
from pygls.server import LanguageServer
from pygls.workspace import TextDocument
except ImportError:
pass
_DISPATCH_RULE = LanguageDispatchRule.new_rule(
"debian/patches/series",
None,
"patches/series",
[
SecondaryLanguage("patches/series", secondary_lookup="path-name"),
],
)
lsp_standard_handler(_DISPATCH_RULE, types.TEXT_DOCUMENT_CODE_ACTION)
lsp_standard_handler(_DISPATCH_RULE, TEXT_DOCUMENT_WILL_SAVE_WAIT_UNTIL)
_RE_LINE_COMMENT = re.compile(r"^\s*(#(?:.*\S)?)\s*$")
_RE_PATCH_LINE = re.compile(
r"""
^ \s* (?P<patch_name> \S+ ) \s*
(?: (?P<options> [^#\s]+ ) \s* )?
(?: (?P<comment> \# (?:.*\S)? ) \s* )?
""",
re.VERBOSE,
)
_RE_UNNECESSARY_LEADING_PREFIX = re.compile(r"(?:(?:[.]{1,2})?/+)+")
_RE_UNNECESSARY_SLASHES = re.compile("//+")
def _all_patch_files(
debian_patches: VirtualPathBase,
) -> Iterable[VirtualPathBase]:
if not debian_patches.is_dir:
return
for patch_file in debian_patches.all_paths():
if patch_file.is_dir or patch_file.path in (
"debian/patches/series",
"./debian/patches/series",
):
continue
if patch_file.name.endswith("~"):
continue
if patch_file.name.startswith((".#", "#", ".")):
continue
parent = patch_file.parent_dir
if (
parent is not None
and parent.path in ("debian/patches", "./debian/patches")
and patch_file.name.endswith(".series")
):
continue
yield patch_file
def _listed_patches(
lines: list[str],
) -> Iterable[str]:
for line in lines:
m = _RE_PATCH_LINE.match(line)
if m is None:
continue
filename = m.group(1)
if filename.startswith("#"):
continue
filename = _RE_UNNECESSARY_LEADING_PREFIX.sub("", filename, count=1)
filename = _RE_UNNECESSARY_SLASHES.sub("/", filename)
if not filename:
continue
yield filename
@lint_diagnostics(_DISPATCH_RULE)
async def _lint_debian_patches_series(lint_state: LintState) -> None:
source_root = lint_state.source_root
if source_root is None:
return None
dpatches = source_root.lookup("debian/patches/")
if dpatches is None or not dpatches.is_dir:
return None
used_patches = set()
all_patches = {pf.path for pf in _all_patch_files(dpatches)}
for line_no, line in enumerate(lint_state.lines):
m = _RE_PATCH_LINE.match(line)
if not m:
continue
groups = m.groupdict()
orig_filename = groups["patch_name"]
filename = orig_filename
patch_start_col, patch_end_col = m.span("patch_name")
orig_filename_start_col = patch_start_col
if filename.startswith("#"):
continue
if filename.startswith(("../", "./", "/")):
sm = _RE_UNNECESSARY_LEADING_PREFIX.match(filename)
assert sm is not None
slash_start, slash_end = sm.span(0)
orig_filename_start_col = slash_end
prefix = filename[:orig_filename_start_col]
filename = filename[orig_filename_start_col:]
slash_range = TERange(
TEPosition(
line_no,
patch_start_col + slash_start,
),
TEPosition(
line_no,
patch_start_col + slash_end,
),
)
skip_use_check = False
if ".." in prefix:
diagnostic_title = f'Disallowed prefix "{prefix}"'
severity = cast("LintSeverity", "error")
skip_use_check = True
else:
diagnostic_title = f'Unnecessary prefix "{prefix}"'
severity = cast("LintSeverity", "warning")
lint_state.emit_diagnostic(
slash_range,
diagnostic_title,
severity,
"debputy",
quickfixes=[
propose_remove_range_quick_fix(
proposed_title=f'Remove prefix "{prefix}"'
)
],
)
if skip_use_check:
continue
if "//" in filename:
for usm in _RE_UNNECESSARY_SLASHES.finditer(filename):
start_col, end_cold = usm.span()
slash_range = TERange(
TEPosition(
line_no,
orig_filename_start_col + start_col,
),
TEPosition(
line_no,
orig_filename_start_col + end_cold,
),
)
lint_state.emit_diagnostic(
slash_range,
"Unnecessary slashes",
"warning",
"debputy",
quickfixes=[propose_correct_text_quick_fix("/")],
)
filename = _RE_UNNECESSARY_SLASHES.sub("/", filename)
patch_name_range = TERange(
TEPosition(
line_no,
patch_start_col,
),
TEPosition(
line_no,
patch_end_col,
),
)
if not filename.lower().endswith((".diff", ".patch")):
lint_state.emit_diagnostic(
patch_name_range,
f'Patch not using ".patch" or ".diff" as extension: "{filename}"',
"pedantic",
"debputy",
)
patch_path = f"{dpatches.path}/{filename}"
if patch_path not in all_patches:
lint_state.emit_diagnostic(
patch_name_range,
f'Non-existing patch "{filename}"',
"error",
"debputy",
)
elif patch_path in used_patches:
lint_state.emit_diagnostic(
patch_name_range,
f'Duplicate patch: "{filename}"',
"error",
"debputy",
)
else:
used_patches.add(patch_path)
unused_patches = all_patches - used_patches
for unused_patch in sorted(unused_patches):
patch_name = unused_patch[len(dpatches.path) + 1 :]
line_count = len(lint_state.lines)
file_range = TERange(
TEPosition(
0,
0,
),
TEPosition(
line_count,
len(lint_state.lines[-1]) if line_count else 0,
),
)
lint_state.emit_diagnostic(
file_range,
f'Unused patch: "{patch_name}"',
"warning",
"debputy",
)
@lsp_completer(_DISPATCH_RULE)
def _debian_patches_series_completions(
ls: "DebputyLanguageServer",
params: CompletionParams,
) -> CompletionList | Sequence[CompletionItem] | None:
doc = ls.workspace.get_text_document(params.text_document.uri)
lint_state = ls.lint_state(doc)
source_root = lint_state.source_root
dpatches = source_root.lookup("debian/patches") if source_root is not None else None
if dpatches is None:
return None
lines = doc.lines
position = doc.position_codec.position_from_client_units(lines, params.position)
line = lines[position.line]
if line.startswith("#"):
return None
try:
line.rindex(" #", 0, position.character)
return None # In an end of line comment
except ValueError:
pass
already_used = set(_listed_patches(lines))
# `debian/patches + "/"`
dpatches_dir_len = len(dpatches.path) + 1
all_patch_files_gen = (
p.path[dpatches_dir_len:] for p in _all_patch_files(dpatches)
)
return [
CompletionItem(
p,
kind=CompletionItemKind.File,
insert_text=f"{p}\n",
label_details=CompletionItemLabelDetails(
description=f"debian/patches/{p}",
),
)
for p in all_patch_files_gen
if p not in already_used
]
@lsp_semantic_tokens_full(_DISPATCH_RULE)
async def _debian_patches_semantic_tokens_full(
ls: "DebputyLanguageServer",
request: SemanticTokensParams,
) -> SemanticTokens | None:
doc = ls.workspace.get_text_document(request.text_document.uri)
lines = doc.lines
position_codec = doc.position_codec
tokens: list[int] = []
string_token_code = SEMANTIC_TOKEN_TYPES_IDS[SemanticTokenTypes.String.value]
comment_token_code = SEMANTIC_TOKEN_TYPES_IDS[SemanticTokenTypes.Comment.value]
options_token_code = SEMANTIC_TOKEN_TYPES_IDS[SemanticTokenTypes.Keyword.value]
sem_token_state = SemanticTokensState(
ls,
doc,
lines,
tokens,
)
async for line_no, line in ls.slow_iter(enumerate(lines)):
if line.isspace():
continue
m = _RE_LINE_COMMENT.match(line)
if m:
start_col, end_col = m.span(1)
start_pos = position_codec.position_to_client_units(
sem_token_state.lines,
Position(
line_no,
start_col,
),
)
sem_token_state.emit_token(
start_pos,
position_codec.client_num_units(line[start_col:end_col]),
comment_token_code,
)
continue
m = _RE_PATCH_LINE.match(line)
if not m:
continue
groups = m.groupdict()
_emit_group(
line_no,
string_token_code,
sem_token_state,
"patch_name",
groups,
m,
)
_emit_group(
line_no,
options_token_code,
sem_token_state,
"options",
groups,
m,
)
_emit_group(
line_no,
comment_token_code,
sem_token_state,
"comment",
groups,
m,
)
return SemanticTokens(tokens)
def _emit_group(
line_no: int,
token_code: int,
sem_token_state: SemanticTokensState,
group_name: str,
groups: Mapping[str, str],
match: re.Match,
) -> None:
value = groups.get(group_name)
if not value:
return None
patch_start_col = match.start(group_name)
position_codec = sem_token_state.doc.position_codec
patch_start_pos = position_codec.position_to_client_units(
sem_token_state.lines,
Position(
line_no,
patch_start_col,
),
)
sem_token_state.emit_token(
patch_start_pos,
position_codec.client_num_units(value),
token_code,
)
|